Utilize new wait extension methods
#8619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
requested review from
kenzieschmoll,
bkonyi,
elliette and
a team
as code owners
| argumentsDescriptorFuture, | ||
| entriesFuture, | ||
| ]).then((result) => populateLists(result[0], result[1])); | ||
| ).wait.then((result) => populateLists(result.$1, result.$2)); |
There was a problem hiding this comment.
interesting, so .wait works on a record too, not just lists? Is there a way to name the record results so that we don't have to use $1 and $2 ?
There was a problem hiding this comment.
So
.waitworks on a record too, not just lists?
Yep, and that's when it shines as it allows you to access specific items with their respective types :D
Is there a way to name the record results so that we don't have to use $1 and $2 ?
The .wait extension only exists for records with just positional fields, but you can destructure them using a pattern. In this case, since the function wasn't using async/await, it took a bit more restructuring. I went ahead and did that in 04334cd
kenzieschmoll
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a bit cleaner in general, but especially so when you need to wait for and access futures with different types.